fix: Restore member xmlName resolution in XML builder root entry pt#344
Merged
Conversation
sichanyoo
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
buildentry point only checksshape.target.traits['smithy.api#xmlName']for the root element name, but doesn't checkshape.traits['smithy.api#xmlName'](the member-level xmlName). This was a regression introduced in #342 — the old code checkedref.location_namefirst, which callers used to pass the resolved member xmlName.This matters for REST XML
httpPayloadmembers where the member'sxmlNameoverrides the target shape'sxmlName(e.g., member hasxmlName: "Hola", target hasxmlName: "Hello"— should serialize as<Hola>).Changes
shape.traits['smithy.api#xmlName']beforeshape.target.traits['smithy.api#xmlName']in the builder's root resolution — consistent with how nested members are already resolved via thelocation_namehelper.Test case
HttpPayloadWithMemberXmlNameprotocol test — member xmlName should win over target xmlName for the root element. All protocol tests passes.