Skip to content

extend OCSF test utils #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptzianos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

extend OCSF test utils #1126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/component/utils/testing/oscf_vulnerability_finding_verification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ func AssertFindingListsMatch(t *testing.T, expectedFindings, actualFindings []*o
// Match found, compare the important fields
t.Run(fmt.Sprintf("Comparing finding %s", key), func(t *testing.T) {
assert.Equal(t, expected.GetFindingInfo().GetTitle(), actual.GetFindingInfo().GetTitle(), "Titles should match")
assert.Equal(t, expected.GetFindingInfo().GetDesc(), actual.GetFindingInfo().GetDesc(), "Descriptions should match")

var expectedDS, actualDS ocsffindinginfo.DataSource
// Use require here because if JSON fails, the rest of the checks are invalid.
Expand Down Expand Up @@ -175,6 +176,7 @@ func AssertFindingListsMatch(t *testing.T, expectedFindings, actualFindings []*o

expectedAC := expectedVuln.GetAffectedCode()[0]
actualAC := actualVuln.GetAffectedCode()[0]
assert.Equal(t, expectedAC.GetStartLine(), actualAC.GetStartLine(), "AffectedCode StartLine should match")
assert.Equal(t, expectedAC.GetEndLine(), actualAC.GetEndLine(), "AffectedCode EndLine should match")
})
// Remove from map to track which expected findings were seen
Expand Down
Loading