Skip to content

Add C++ specialized Dockerfile #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toshi0806 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add C++ specialized Dockerfile #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21e561e
Add C++ specialized Dockerfile with CI support [build-cpp]
toshi0806 Oct 24, 2025
280329e
Fix Eigen installation to use /bin/sh compatible syntax [build-cpp]
toshi0806 Oct 24, 2025
c5d1285
Fix Eigen3 path replacement in OR-Tools build [build-cpp]
toshi0806 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 91 additions & 1 deletion .github/workflows/build-staged.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
build_full: ${{ steps.strategy.outputs.build_full }}
build_full_amd64: ${{ steps.strategy.outputs.build_full_amd64 }}
build_full_arm64: ${{ steps.strategy.outputs.build_full_arm64 }}
build_cpp: ${{ steps.strategy.outputs.build_cpp }}
platforms: ${{ steps.strategy.outputs.platforms }}
is_main_branch: ${{ steps.strategy.outputs.is_main_branch }}
steps:
Expand Down Expand Up @@ -74,6 +75,7 @@ jobs:
# Default values
BUILD_LITE="true"
BUILD_FULL="false"
BUILD_CPP="false"
PLATFORMS="linux/amd64"
IS_MAIN="false"

Expand All @@ -87,9 +89,12 @@ jobs:
if [[ "$COMMIT_MESSAGE" == *"[build-all]"* ]]; then
BUILD_LITE="true"
BUILD_FULL="true"
BUILD_CPP="true"
PLATFORMS="linux/amd64,linux/arm64" # Build both architectures
elif [[ "$COMMIT_MESSAGE" == *"[build-full]"* ]]; then
BUILD_FULL="true"
elif [[ "$COMMIT_MESSAGE" == *"[build-cpp]"* ]]; then
BUILD_CPP="true"
fi

# For pull requests: build Full version on x86_64 to catch issues early
Expand Down Expand Up @@ -144,13 +149,15 @@ jobs:
echo "build_full=$BUILD_FULL"
echo "build_full_amd64=$BUILD_FULL_AMD64"
echo "build_full_arm64=$BUILD_FULL_ARM64"
echo "build_cpp=$BUILD_CPP"
echo "platforms=$PLATFORMS"
echo "is_main_branch=$IS_MAIN"
} >> "$GITHUB_OUTPUT"

echo "📋 Build Strategy:"
echo " Lite: $BUILD_LITE"
echo " Full: $BUILD_FULL (amd64: $BUILD_FULL_AMD64, arm64: $BUILD_FULL_ARM64)"
echo " C++: $BUILD_CPP"
echo " Platforms: $PLATFORMS"
echo " Main branch: $IS_MAIN"

Expand Down Expand Up @@ -371,31 +378,110 @@ jobs:

echo "✅ All tests passed!"

# Stage 3.5: Build C++ Specialized Version
build-cpp:
needs: determine-strategy
if: needs.determine-strategy.outputs.build_cpp == 'true'
strategy:
matrix:
include:
- platform: linux/amd64
runner: ubuntu-24.04
arch: amd64
- platform: linux/arm64
runner: ubuntu-24.04-arm
arch: arm64
runs-on: ${{ matrix.runner }}
permissions:
contents: read
packages: write
steps:
- name: Get current date
id: date
run: echo "date=$(date +'%Y%m%d')" >> "$GITHUB_OUTPUT"

- name: Checkout
uses: actions/checkout@v4

- name: Set up QEMU
if: matrix.platform == 'linux/arm64' && matrix.runner == 'ubuntu-latest'
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
buildkitd-config-inline: |
[dns]
nameservers=["1.1.1.1"]

- name: Login to Container Registry
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Extract metadata
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
tags: |
type=raw,value=cpp-${{ steps.date.outputs.date }}-${{ matrix.arch }}
type=raw,value=cpp-latest-${{ matrix.arch }},enable=${{ github.ref == 'refs/heads/main' }}
type=sha,prefix=cpp-,suffix=-${{ matrix.arch }}

- name: Build and push C++ version
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfile.cpp
platforms: ${{ matrix.platform }}
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha,scope=cpp-${{ matrix.arch }}
cache-to: type=gha,mode=max,scope=cpp-${{ matrix.arch }}

- name: Test C++ version
if: github.event_name != 'pull_request'
run: |
IMAGE_TAG="${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:cpp-${{ steps.date.outputs.date }}-${{ matrix.arch }}"

echo "🔍 Testing C++ container..."
docker run --rm "$IMAGE_TAG" g++ --version
docker run --rm "$IMAGE_TAG" bash -c "echo '#include <atcoder/all>' | g++ -x c++ - -c -o /dev/null"
echo "✅ C++ tests passed!"

# Stage 4: Summary and notification
build-summary:
needs: [determine-strategy, build-lite, build-full]
needs: [determine-strategy, build-lite, build-full, build-cpp]

Copilot AI Oct 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build-summary job unconditionally depends on build-cpp, but build-cpp only runs conditionally (when build_cpp == 'true'). This will cause the summary job to be skipped when C++ builds are not triggered. Use if: always() on individual jobs or make the dependency conditional.

Suggested change
needs: [determine-strategy, build-lite, build-full, build-cpp]
needs: [determine-strategy, build-lite, build-full]

Copilot uses AI. Check for mistakes.
if: always()
runs-on: ubuntu-latest
steps:
- name: Build Summary
env:
LITE_BUILD: ${{ needs.determine-strategy.outputs.build_lite }}
FULL_BUILD: ${{ needs.determine-strategy.outputs.build_full }}
CPP_BUILD: ${{ needs.determine-strategy.outputs.build_cpp }}
PLATFORMS: ${{ needs.determine-strategy.outputs.platforms }}
LITE_RESULT: ${{ needs.build-lite.result || 'skipped' }}
FULL_RESULT: ${{ needs.build-full.result || 'skipped' }}
CPP_RESULT: ${{ needs.build-cpp.result || 'skipped' }}
run: |
{
echo "## 🚀 Build Summary"
echo ""
echo "### 📋 Strategy"
echo "- **Lite Build**: $LITE_BUILD"
echo "- **Full Build**: $FULL_BUILD"
echo "- **C++ Build**: $CPP_BUILD"
echo "- **Platforms**: $PLATFORMS"
echo ""
echo "### 🎯 Results"
echo "- **Lite Version**: $LITE_RESULT"
echo "- **Full Version**: $FULL_RESULT"
echo "- **C++ Version**: $CPP_RESULT"
echo ""

if [[ "$LITE_RESULT" == "success" ]]; then
Expand All @@ -405,4 +491,8 @@ jobs:
if [[ "$FULL_RESULT" == "success" ]]; then
echo "✅ **Full version built successfully** - Complete development environment ready!"
fi

if [[ "$CPP_RESULT" == "success" ]]; then
echo "✅ **C++ version built successfully** - Specialized C++ environment ready!"
fi
} >> "$GITHUB_STEP_SUMMARY"
Loading
Loading