-
Notifications
You must be signed in to change notification settings - Fork 1
ci: add ai-code-review caller #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Caller template: AI Code Review (one-shot, inline) — calls the ai-review reusable. | ||
| # Distributed by scripts/distribute-workflow.sh as | ||
| # .github/workflows/ai-code-review.yml in each target repository. | ||
| # The ref / model / language tokens below are substituted at distribution time. | ||
| name: AI Code Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, ready_for_review, synchronize] # synchronize: re-review on each push. concurrency below cancels superseded runs. Drop synchronize if cost is a concern. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ℹ️ [LOW] 9行目のインラインコメントが非常に長く、YAMLの可読性を損なっています。コメントは別行に分けるか、ワークフローの説明として |
||
|
|
||
| concurrency: | ||
| group: ai-code-review-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| review: | ||
| uses: smkwlab/.github/.github/workflows/ai-review.yml@v1 | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| secrets: | ||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| gemini_api_key: ${{ secrets.GEMINI_API_KEY }} | ||
| with: | ||
| model_code: claude-sonnet-4-6 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚨 [HIGH] モデルコード |
||
| review_mode: CODE | ||
| language: Japanese | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ [LOW] コメント冒頭(1〜4行目)に「Distributed by scripts/distribute-workflow.sh」とあり、このファイルが配布スクリプトによって生成されるテンプレートであることが示されています。しかし、このリポジトリに
scripts/distribute-workflow.shが存在するか、またはこのファイルが手動で配置されたものかが不明です。テンプレートとして管理するのであれば、実際の配布元リポジトリとの同期方法を明確にしておくことを推奨します。