Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Gerson silva filho - Adding support to "links" instead of "_links".#6

Open
GersonSilvaFilho wants to merge 3 commits into
smoope:masterfrom
GersonSilvaFilho:GersonSilvaFilho-patch-1
Open

Gerson silva filho - Adding support to "links" instead of "_links".#6
GersonSilvaFilho wants to merge 3 commits into
smoope:masterfrom
GersonSilvaFilho:GersonSilvaFilho-patch-1

Conversation

@GersonSilvaFilho
Copy link
Copy Markdown

No description provided.

Adding Link resolver with "links" search instead of "_links".
Adding new TraversonModifiedJsonHalLinkResolver option.
Correcting file name.
@GersonSilvaFilho GersonSilvaFilho changed the title Gerson silva filho patch 1 Gerson silva filho - Adding support to "links" instead of "_links". Aug 7, 2017
@vicmosin
Copy link
Copy Markdown
Member

vicmosin commented Aug 8, 2017

Hi @GersonSilvaFilho ,
many thanks for your PR but I believe this change is too private case and can be solved as a resolver extension in your local project.. HAL standard clearly defined the _links property.

@GersonSilvaFilho
Copy link
Copy Markdown
Author

GersonSilvaFilho commented Aug 8, 2017

Hi @vicmosin

Thanks for your reply =)

Yes at first i thought this was something really specific, that's why i added the name "TraversonModifiedJsonHalLinkResolver". Now i've found out that there is an specific protocol called Siren that follow same principles than HAL and don't use the underscore.

https://github.com/kevinswiber/siren

Actually the API that i'm using is following this pattern. Do you think that would be good to add it? I would correct the names to "TraversonSirenLinkResolver" and ".Siren"or something like that.

@vicmosin
Copy link
Copy Markdown
Member

vicmosin commented Aug 8, 2017

Sure. But please provide appropriate tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants