Skip to content

Player: update alliance cache immediately in joinAlliance#2432

Merged
hemberger merged 1 commit into
smrealms:mainfrom
hemberger:fix-player-cache
May 11, 2026
Merged

Player: update alliance cache immediately in joinAlliance#2432
hemberger merged 1 commit into
smrealms:mainfrom
hemberger:fix-player-cache

Conversation

@hemberger
Copy link
Copy Markdown
Member

This fixes an issue where the alliance roster does not immediately update when a player clicks the "Join" button on the Alliance Roster page.

This fixes an issue where the alliance roster does not immediately
update when a player clicks the "Join" button on the Alliance Roster
page.
@hemberger hemberger added the bug label May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.62%. Comparing base (6db4d94) to head (3dd7e15).

Files with missing lines Patch % Lines
src/lib/Smr/Player.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2432      +/-   ##
============================================
- Coverage     35.63%   35.62%   -0.01%     
- Complexity     4313     4314       +1     
============================================
  Files           132      132              
  Lines         12896    12898       +2     
============================================
  Hits           4595     4595              
- Misses         8301     8303       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hemberger hemberger merged commit 149fe58 into smrealms:main May 11, 2026
8 of 10 checks passed
@hemberger hemberger deleted the fix-player-cache branch May 11, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant