fix(phpstan): resolver 3 erros nível 8 (SMSGoError + Paginated) - #1
Merged
Merged
Conversation
… generics)
- SMSGoError::$code sobrescrevia Exception::$code como `readonly string`, o que
o PHPStan (e o PHP 8.4) rejeitam ("readonly overrides readwrite" + tipo nativo
sobre propriedade herdada sem tipo). Passa a ser declarada sem tipo nativo nem
readonly, com o tipo string via PHPDoc; atribuída no construtor.
- Paginated::fromArray() inferia self<array|U>, divergindo do retorno condicional
self<array>|self<U>. Ramos com/sem mapper separados p/ inferência correta.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI estava vermelho em todos os PHP (8.1–8.4) no step PHPStan (nível 8), 3 erros:
SMSGoError::$codesobrescreviaException::$codecomoreadonly string→ "readonly overrides readwrite" + "should not have a native type". Agora declarada sem tipo nativo/readonly, tipostringvia PHPDoc, atribuída no ctor. Superfície pública ($e->code) preservada.Paginated::fromArray()retornavaself<array<string,mixed>|U>mas o tipo condicional declarado éself<array<string,mixed>>|self<U>. Ramos com/sem mapper separados p/ inferência correta.Pré-requisito para publicar o SDK no Packagist (release exige CI verde).
🤖 Generated with Claude Code