Flush output stream after printing state of control lines. - #6
Open
msemeniuk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lack of stdout flushing after printing state of control lines causes unpredictable delays when we are going to redirect stdout to file or use pipe to next process.
Testing:
env: Linux Debian bookworm/sid 5.14.0-2-amd64 #1 SMP Debian 5.14.9-2 (2021-10-03) x86_64 GNU/Linux
prereq: USB serial converter or phy serial port
Run
./jpnevulator -t /dev/ttyUSB0 -r -C -g - S -a 1>1.txt, next after 3-5 seconds kill it with ctrl+cFile 1.txt should include something like:
1.txt file will be empty without flushing stdout.