Skip to content

use which.max to keep up with latest changes in R 3.6#49

Open
korseby wants to merge 1 commit intomasterfrom
reducedPeaklist
Open

use which.max to keep up with latest changes in R 3.6#49
korseby wants to merge 1 commit intomasterfrom
reducedPeaklist

Conversation

@korseby
Copy link
Copy Markdown
Collaborator

@korseby korseby commented Mar 9, 2020

PR for issue #48

Don't merge yet. We wait until the issue is fixed.

@korseby korseby requested a review from sneumann March 9, 2020 12:16
@sneumann
Copy link
Copy Markdown
Owner

Hi, can we haz' a unit test for #48 ? Yours, Steffen

@korseby
Copy link
Copy Markdown
Collaborator Author

korseby commented Mar 23, 2020

@sneumann Where do I put the test(s) in this repo?

@sneumann
Copy link
Copy Markdown
Owner

sneumann commented May 6, 2020

Tests go into https://github.com/sneumann/CAMERA/tree/master/inst/unitTests
Yours, Steffen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants