Export core function to identify isotopes#52
Open
jorainer wants to merge 2 commits intosneumann:masterfrom
Open
Export core function to identify isotopes#52jorainer wants to merge 2 commits intosneumann:masterfrom
jorainer wants to merge 2 commits intosneumann:masterfrom
Conversation
- Export the core functionality to find isotopes among a grouped set of features (aka pseudo spectrum). Issue sneumann#51.
sneumann
approved these changes
Mar 21, 2020
| }; | ||
|
|
||
| #Entferne Hypothesen, welche gegen OID-Score&Kausalität verstossen! | ||
| #Entferne Hypothesen, welche gegen OID-Score&Kausalitaet verstossen! |
Owner
There was a problem hiding this comment.
Bonus points for translating german comments ...
Author
There was a problem hiding this comment.
:) I leave that to you :) I just removed to german characters because devtools::document() failed crying for non-UTF8 encoding.
Owner
|
looks good to me. I'd like to try merge in chronological order |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exports the first function to identify isotopes which is used by the
findIsotopesfunction. Currently no post-processing is performed. Also, there is a second methodfindIsotopesWithValidationthat uses a different code to determine isotopes - it might be eventually better to export that one too.