Skip to content

Conversation

@NinaDen
Copy link
Contributor

@NinaDen NinaDen commented Oct 9, 2021

Describe what changes this pull request brings

  1. This pull request adds prompts defaults values to create template page
  2. This default values are used in extension
  3. The default values are added to animation

Describe any additional changes
N/A

Steps to test

  1. Open create template page
  2. Create template with prompts default values
  3. Confirm that the default values appear when create the template in the extension
  4. Confirm that the default values appear in animation

Screenshots

Animation with default values:
screencast 2021-10-09 15-55-12

Checklist

  • I've checked for typos
  • I've made sure overall structure consistency is preserved
  • I've made sure overall headings hierarchy is preserved
  • I've reread proposed changes twice

TODO

References
Issue Add default values to prompts #108

@NinaDen NinaDen requested review from bolotskydev and lnikell October 9, 2021 11:13
Copy link
Contributor

@lxkuz lxkuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @NinaDen!

{prompts.map((item, index) => (
<Prompt key={index} item={item} index={index} />
))}
</ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the point of this huge change... indent change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants