Add one-shot CLI over shared rust docs runtime#58
Merged
Conversation
Resolve conflicts by keeping blocking cache_crate API and CLI tests while adopting features parameter support from main.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8479a5c. Configure here.
| .get("status") | ||
| .and_then(serde_json::Value::as_str) | ||
| .is_some_and(|status| status == "error") | ||
| || object.contains_key("error") |
There was a problem hiding this comment.
CLI zero exit on workspace
Medium Severity
call cache-crate decides failure via output_indicates_error, which ignores status: "workspace_detected". That response means docs were not cached, yet the process exits 0. MCP background caching treats the same outcome as a failed task, so CLI and MCP disagree on success.
Reviewed by Cursor Bugbot for commit 8479a5c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
RustDocsRuntimeshared by the MCP service and CLI paths.rust-docs-mcp call <tool> --params <json>.servebehavior as the existing long-running MCP stdio server.call cache-cratecompletes download, rustdoc generation, and search index creation before exiting.CLI examples
Verification
cargo fmt -p rust-docs-mcp -- --checkcargo build -p rust-docs-mcpcargo clippy -p rust-docs-mcpcargo test -p rust-docs-mcp --no-runcargo test -p rust-docs-mcp --test integration_tests test_runtime_cache_blocking -- --nocapturecargo test -p rust-docs-mcp --test integration_tests test_runtime_search_fuzzy -- --nocapturecargo test -p rust-docs-mcp --test integration_tests test_cli_call -- --nocapturecall cache-cratecall search-items-fuzzycall list-cached-cratestest_cache_updateunder resource contention.test_cache_updatealone: passed.27 passed; 0 failed.Notes
cache_operationsremains MCP-oriented because task state is in-memory and only meaningful for a long-running process. The CLIcache-cratepath is intentionally blocking.Note
Cursor Bugbot is generating a summary for commit 8479a5c. Configure here.