Add infracost configuration#84
Open
Nick (stanch) wants to merge 1 commit into
Open
Conversation
Contributor
|
Gave it a test-drive Nick (@stanch) - works really well! I think though it might be useful to perhaps target a more "filled" vars file as enabling destinations drives up the cost quite significantly. For AWS now only the S3 Loaders for bad and enriched are enabled as default so that cost point is a little on the low end. |
Josh (jbeemster)
approved these changes
Nov 13, 2023
Contributor
Josh (jbeemster)
left a comment
Josh (jbeemster)
left a comment
There was a problem hiding this comment.
Approved! Though would generally want this kind of addition to be done with an issue + commit link like everything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No GCP because many resources are not supported yet