threadpool: fix: min thread amount was ignored on WinXP & Win Vista+ ThreadPool unused w/ Ninja generator

[sergio-nsk]

No description provided.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.70%. Comparing base (8471805) to head (3f3b370).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   59.00%   58.70%   -0.31%     
==========================================
  Files          32       32              
  Lines        2603     2603              
  Branches      524      524              
==========================================
- Hits         1536     1528       -8     
- Misses        732      741       +9     
+ Partials      335      334       -1     

Flag	Coverage Δ
macos	55.20% <ø> (-0.33%)	⬇️
macos_duktape	60.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This pull request addresses two issues with the threadpool implementation on Windows: ensuring the minimum thread count is respected on Windows XP, and fixing the selection of the appropriate threadpool implementation when using the Ninja generator on Windows Vista and later.

Changes:

• Added logic to create minimum threads when jobs are enqueued in the WinXP threadpool implementation
• Modified CMakeLists.txt to check CMAKE_SYSTEM_VERSION in addition to CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION for selecting the appropriate threadpool implementation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
threadpool_winxp.c	Adds a while loop to ensure minimum threads are created when enqueueing jobs
CMakeLists.txt	Extends the condition for selecting threadpool_winvista.c to include CMAKE_SYSTEM_VERSION check for Ninja generator support

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.