Skip to content

Prevent import fixer from preprending ../ with ./#92

Open
rehmsen wants to merge 1 commit into
soates:masterfrom
rehmsen:master
Open

Prevent import fixer from preprending ../ with ./#92
rehmsen wants to merge 1 commit into
soates:masterfrom
rehmsen:master

Conversation

@rehmsen

@rehmsen rehmsen commented Sep 7, 2018

Copy link
Copy Markdown

That bug was fixed in the display of the fix, but because import fixing
was using a copy-and-pasted version of the path normalization code,
it never got the fix.

I tested this locally and now it actually works.

Fixes #37 (see PR #47 for the first attempt only fixing the display).

That bug was fixed in the display of the fix, but because import fixing
was using a copy-and-pasted version of the path normalization code,
it never got the fix.

I tested this locally and now it actually works.

Fixes soates#37 (see PR soates#47 for the first attempt only fixing the display).

@abarrows abarrows left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants