Skip to content

🛡️ Sentinel: [MEDIUM] Fix error handling exposing internal details #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
socialawy-dev wants to merge 1 commit into from
Closed

🛡️ Sentinel: [MEDIUM] Fix error handling exposing internal details #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/audioformation/server/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ async def ingest_files(
shutil.copyfileobj(file.file, buffer)
except Exception as e:
shutil.rmtree(tmp_dir, ignore_errors=True)
raise HTTPException(status_code=500, detail=f"Upload failed: {e}")
logger.exception(f"Ingest upload failed: {e}")
raise HTTPException(status_code=500, detail="Upload failed")
Comment on lines +188 to +189
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation catches all exceptions and returns a 500 Internal Server Error. However, sanitize_filename raises a ValueError if the input is invalid (e.g., empty after sanitization), which is a client-side error that should return a 400 Bad Request. Returning a 500 error for client-side issues can mislead users and trigger unnecessary server-side alerts.

Additionally, when using logger.exception(), the exception details (message and traceback) are automatically captured and appended to the log output. Including {e} in the message string is redundant and leads to cluttered logs where the error message appears twice.

        if isinstance(e, ValueError):
            raise HTTPException(status_code=400, detail=str(e))
        logger.exception("Ingest upload failed")
        raise HTTPException(status_code=500, detail="Upload failed")


background_tasks.add_task(
_run_with_status,
Expand Down
Loading