[codex] Wire AtmosphereState into scene runtime#28
Merged
wow-miley merged 1 commit intoMay 24, 2026
Merged
Conversation
wow-miley
deleted the
miley/pho-13-wire-atmospherestate-into-cognitivesceneruntime-and
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the passive AtmosphereState subsystem to CognitiveSceneRuntime behind SceneConfiguration.enableAtmosphere, with initialAtmosphere defaults and setAtmosphere replacement semantics. SceneSnapshot now exposes atmosphere and includes it in equality/hashCode, and runtime/snapshot tests cover disabled, enabled, custom initial, replacement, and equality behavior. The migration notes document how consumers, including Lumos, read the snapshot field. Validated with ./gradlew ktlintFormat, ./gradlew jvmTest, ./gradlew iosSimulatorArm64Test, and git diff --check.