PHO-14: Add AtmosphereChoreographer for transitions between atmosphere states#31
Merged
wow-miley merged 1 commit intoMay 24, 2026
Conversation
Introduces AtmosphereChoreographer with phase-accumulator integration, two-track easing (eased amplitudes, linear crossfade weights), color snapshots for bipolar transitions, and pattern crossfade. Wires it into CognitiveSceneRuntime between agent and emitter ticks, surfacing SceneSnapshot.atmosphereTransition. Adds eager, reluctant, overshoot, and settled easings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wow-miley
deleted the
miley/pho-14-add-atmospherechoreographer-for-transitions-between
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AtmosphereChoreographer(phosphor-core/choreography/) with phase accumulators (pulsePhase/patternPhaseintegratedt × frequencyto avoid discontinuities), two-track easing (eased amplitudes, linear color/pattern crossfade weights), snapshot-based color crossfade for bipolar transitions, and pattern crossfade viapatternFrom+patternBlend.eager,reluctant,overshoot, andsettledeasings intimeline/Easing.kt(wired throughbyName/availableNames) and encodes the 20-entry default transition table inside the choreographer with a 1.1s easeInOut fallback.CognitiveSceneRuntime(constructed whenenableAtmosphereis true), routessetAtmosphere(state)through it, addssetAtmospherePreset(name), ticks the choreographer between agents (step 3) and emitters (step 5), and surfacesSceneSnapshot.atmosphereTransitionalongside the existingatmospherefield.update(dt)ordering and the two atmosphere entry points indocs/COGNITIVE_SCENE_RUNTIME_MIGRATION.md.Test plan
./gradlew jvmTest(AtmosphereChoreographerTest: 17/17; CognitiveSceneRuntimeTest: 11/11; full suite green)./gradlew ktlintFormat./gradlew compileKotlinIosSimulatorArm64🤖 Generated with Claude Code