PHO-16: Add LumosRenderer interface and VoxelFrame data class#36
Merged
wow-miley merged 1 commit intoMay 25, 2026
Merged
Conversation
Introduces the parallel renderer abstraction for :phosphor-lumos: LumosRenderTarget enum, @serializable VoxelFrame (with VoxelCell, VoxelAmbient, optional VoxelGlyphState), and LumosRenderer<T> interface. Sibling to PhosphorRenderer/SimulationFrame; both pipelines coexist. Adds explicit kotlinx-serialization-core/json deps since phosphor-core declares them as implementation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wow-miley
deleted the
miley/pho-16-add-lumosrenderer-interface-and-voxelframe-data-class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:phosphor-lumos:LumosRenderTargetenum (VOXEL_NATIVE,VOXEL_TERMINALreserved for Wave 2),LumosRenderer<out T>interface, and@SerializableVoxelFrame/VoxelCell/VoxelAmbient/ optionalVoxelGlyphState.PhosphorRenderer/SimulationFrame— both pipelines coexist because the voxel and cell-based renderers produce different geometric primitives; KDoc cross-references both directions. No concrete renderer orVoxelFrameBuilder(those are PHO-17 / PHO-18).kotlinx-serialization-coreand-jsonexplicitly inphosphor-lumos/build.gradle.ktssince:phosphor-coreexposes them asimplementation.Test plan
./gradlew :phosphor-lumos:jvmTest— JSON round-trip (full / null-glyph / empty cells), per-field equality, enum exhaustiveness +valueOfall green./gradlew :phosphor-lumos:build—allTestsacross JVM/JS/WasmJS and the iOS compile gate green./gradlew ktlintFormat— clean🤖 Generated with Claude Code