PHO-17: Add VoxelFrameBuilder with pattern, color, and geometry pipeline#37
Merged
wow-miley merged 1 commit intoMay 25, 2026
Conversation
Introduces VoxelFrameBuilder and LumosRenderConfig in :phosphor-lumos so a SceneSnapshot can be translated into a VoxelFrame each tick: the builder owns continuous pulse/pattern/rotation phase accumulators, evaluates the seven AtmospherePattern formulas (with linear pattern crossfade across transitions), applies bipolar boundary shrink with a smoothstep falloff, and computes per-voxel color via HSL — falling back to OKLab crossfade when a transition changes bipolarStrength so amber↔purple no longer passes through pink. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wow-miley
deleted the
miley/pho-17-add-voxelframebuilder-pattern-color-and-geometry-pipeline
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VoxelFrameBuilderin:phosphor-lumos: a stateful translator fromSceneSnapshot+VoxelSpheretoVoxelFrame. Owns continuous pulse/pattern/rotation phase accumulators, evaluates all sevenAtmospherePatternformulas with linear crossfade between source and target patterns, applies bipolar boundary shrink via smoothstep, and computes per-voxel color through HSL with an OKLab crossfade wheneverfrom.bipolarStrength != to.bipolarStrengthso distant-hue transitions stop passing through forbidden midpoints.LumosRenderConfigwithglobalYSquashOverride,enableGlyphCarving, andomitBelowScaleknobs; the per-voxel sRGB light-budget contract is documented on the config rather than enforced by the builder.omitBelowScalefiltering,globalYSquashOverrideY-only effect, ambient glow shape,IllegalStateExceptionwhen atmosphere is absent, and tick/timestamp passthrough.Test plan
./gradlew :phosphor-lumos:jvmTest./gradlew ktlintCheck./gradlew :phosphor-lumos:compileKotlinIosSimulatorArm64(iOS compile gate)🤖 Generated with Claude Code