Refuse requests assigned to closed HTTP/2 connections - #246
Merged
Conversation
Assisted-By: devx/618580b0-d55f-4c2e-95b6-87e648f60543
samuel-williams-shopify
force-pushed
the
refuse-closed-http2-connection
branch
from
August 31, 2026 03:32
a798026 to
a2d8738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An HTTP/2 connection can close after the pool acquires it but before
Client#callbegins writing the request. At the existingclosed?check, no response stream has been created and no request bytes have been written, so the request is known not to have been processed.Raise
Protocol::HTTP::RefusedErrorin this case soAsync::HTTP::Clientcan safely retry the request, including non-idempotent requests with rewindable bodies.HTTP/1 already has equivalent behavior in
Protocol::HTTP1::Connection#write_request, which converts failures before a complete request is emitted intoProtocol::HTTP::RefusedError.Tests
Protocol::HTTP::RefusedErrorfor a POST request.bundle exec bake test: 256 passed, 3 skipped.Types of Changes
Bug fix
Contribution