Skip to content

Serve dedicated cluster and endpoint discovery services - #10

Merged
samuel-williams-shopify merged 4 commits into
mainfrom
dedicated-cluster-endpoint-discovery
Aug 7, 2026
Merged

Serve dedicated cluster and endpoint discovery services#10
samuel-williams-shopify merged 4 commits into
mainfrom
dedicated-cluster-endpoint-discovery

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Replace the supervisor ADS endpoint with dedicated CDS and EDS services.
  • Retain supervisor-owned cluster generation by default, including protocol selection, active health checks, and ORCA load-balancing policy.
  • Add publish_clusters: false so bootstrap configuration or another control plane can own clusters while the supervisor publishes live worker assignments through EDS.
  • Point generated clusters back to the supervisor dedicated EDS service through a configurable management cluster.
  • Avoid redundant EDS version bumps for unchanged assignments and publish an empty assignment when the final worker is removed.
  • Update the guide and Envoy integration fixture for both CDS+EDS and EDS-only topologies.

This leaves ADS available to another control plane. EDS-only mode additionally leaves cluster configuration available to bootstrap or an external CDS/ADS control plane.

Uses the dedicated discovery services released in async-grpc-xds v0.4.0.

This supersedes the EDS-only direction in #9 while retaining its endpoint deduplication and test/documentation improvements.

Verification

  • 43 unit examples, 92 assertions
  • RuboCop
  • Documentation coverage: 40/40
  • Docker Compose integration matrix covering CDS+EDS and EDS-only modes with real Envoy, a supervisor, and two Falcon workers

epk and others added 4 commits August 6, 2026 21:15
@epk @samuel-williams-shopify
Serve dedicated cluster and endpoint discovery services.
48040cf 
Replace the supervisor ADS endpoint with dedicated CDS and EDS services while retaining dynamic cluster generation, protocol validation, health checks, and ORCA policy configuration.

Generated clusters point their endpoint subscriptions back to the same management cluster over EDS, leaving Envoy ADS available for another control plane. Endpoint assignments are only republished when they change.

Update the control-plane fixture and guide for the split discovery topology, and verify that Envoy discovers both the dynamic cluster and its supervised Falcon workers.
@samuel-williams-shopify
Use released async-grpc-xds v0.4
a58cd87
@samuel-williams-shopify
Allow cluster publication to be disabled.
167660e
@samuel-williams-shopify
Cover ORCA validation without cluster publication.
b5cbbcc
@samuel-williams-shopify
samuel-williams-shopify merged commit 557baa2 into main Aug 7, 2026
52 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the dedicated-cluster-endpoint-discovery branch August 7, 2026 09:11
@samuel-williams-shopify samuel-williams-shopify mentioned this pull request Aug 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuel-williams-shopify @epk