Skip to content

Accept listener as positional argument - #4

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
positional-listener
Jul 31, 2026
Merged

Accept listener as positional argument#4
samuel-williams-shopify merged 1 commit into
mainfrom
positional-listener

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Align the Envoy supervision hook with Falcon::Environment::Server#prepare_worker!, where both the instance and listener are required lifecycle objects.

This supports socketry/falcon#356.

Verification:

  • bundle exec bake test (26 tests, 58 assertions)
  • bundle exec rubocop
  • bundle exec bake decode:index:coverage lib (35/35)

@samuel-williams-shopify
samuel-williams-shopify merged commit e9d94e8 into main Jul 31, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant