Wrap loop_yield() in rb_protect() - #217
Merged
Merged
Conversation
tavianator
force-pushed
the
uninterruptible-cancellation
branch
from
August 26, 2026 21:28
7946dee to
d80c7dc
Compare
`IO_Event_Selector_URing_Waiting_cancel_and_wait` is designed to keep on-stack variables alive while io_uring might still access them. But if the fiber is interrupted inside the `while (waiting->completion)` loop, we may not wait long enough. Fix this by wrapping the loop body in `rb_protect` so we can clean up completely. Fixes: #216
Signed-off-by: Samuel Williams <samuel.williams@shopify.com> Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
Signed-off-by: Samuel Williams <samuel.williams@shopify.com> Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
samuel-williams-shopify
force-pushed
the
uninterruptible-cancellation
branch
from
August 26, 2026 23:05
f479246 to
93c3b62
Compare
ioquatix
pushed a commit
that referenced
this pull request
Aug 27, 2026
`IO_Event_Selector_URing_Waiting_cancel_and_wait` is designed to keep on-stack variables alive while io_uring might still access them. But if the fiber is interrupted inside the `while (waiting->completion)` loop, we may not wait long enough. Fix this by wrapping the loop body in `rb_protect` so we can clean up completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO_Event_Selector_URing_Waiting_cancel_and_waitis designed to keepon-stack variables alive while io_uring might still access them. But if
the fiber is interrupted inside the
while (waiting->completion)loop,we may not wait long enough. Fix this by wrapping the loop body in
rb_protectso we can clean up completely.Types of Changes
Contribution