Skip to content

Fix premature io_uring completion reuse - #219

Merged
ioquatix merged 2 commits into
mainfrom
fix/uring-completion-lifecycle
Aug 27, 2026
Merged

Fix premature io_uring completion reuse#219
ioquatix merged 2 commits into
mainfrom
fix/uring-completion-lifecycle

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • track operation completion independently from the attached waiter
  • recycle completion records only after both the operation and cancellation completions have been processed
  • add a regression test covering cancellation followed by immediate completion reuse

Testing

  • PR CI

@ioquatix ioquatix mentioned this pull request Aug 27, 2026
Open
@samuel-williams-shopify @ioquatix
Add completion reuse regression test
d587418 
Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
@samuel-williams-shopify @ioquatix
Preserve pending io_uring completions
91521ea 
Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
@ioquatix
ioquatix force-pushed the fix/uring-completion-lifecycle branch from 6c65fb3 to 91521ea Compare August 27, 2026 00:09
@ioquatix
ioquatix merged commit 98f7de3 into main Aug 27, 2026
58 of 64 checks passed
@ioquatix
ioquatix deleted the fix/uring-completion-lifecycle branch August 27, 2026 00:14
ioquatix pushed a commit that referenced this pull request Aug 27, 2026
@samuel-williams-shopify @ioquatix
Fix premature io_uring completion reuse. (#219)
79731dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuel-williams-shopify @ioquatix