Rollback io_uring completion setup failures - #221
Open
samuel-williams-shopify wants to merge 4 commits into
Open
Rollback io_uring completion setup failures#221samuel-williams-shopify wants to merge 4 commits into
samuel-williams-shopify wants to merge 4 commits into
Conversation
Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
Assisted-By: devx/efad4cc8-cf12-4d6e-8c55-6f2c3a6683d2
Contributor
Author
|
Updated based on review feedback: the selector-level SQE failure field, private test methods, and regression test have been removed. The PR now contains only the lifecycle fix. The PR description documents why deterministic coverage would require either a test-only native build or external liburing interposition plus non-production observability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing limitation
A deterministic regression requires forcing
io_get_sqe()to raise after a completion record has been acquired. The initial test implemented that with a selector field and private native methods, but that placed fault-injection behavior in the released implementation. Those hooks and the test have been removed.A future test could use a test-only native build or a Linux subprocess with liburing symbol interposition, provided it can expose the leaked completion state without adding production introspection.
Testing
bundle exec bake test(296 passed, 21 skipped locally)