Fix rightBeforeLoadingScene method overloading#585
Open
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Open
Fix rightBeforeLoadingScene method overloading#585alxbilger wants to merge 2 commits intosofa-framework:masterfrom
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Conversation
Contributor
|
The line your are pointing are rather old and calls that code (un SofaRuntime/init.py): def unloadModules():
""" Call this function to unload python modules and to force their reload
(useful to take into account their eventual modifications since
their last import).
"""
global __SofaPythonEnvironment_importedModules__
toremove = [name for name in sys.modules if not name in __SofaPythonEnvironment_importedModules__ and not name in __SofaPythonEnvironment_modulesExcludedFromReload ]
for name in toremove:
del(sys.modules[name]) # unload itI think this was implemented to force the reloading of python modules when loading a new python scene. The hot-reload mechanism as not been really updated since Sofapython2 and it would be worth some cleaning/refreshing. |
Co-authored-by: Damien Marchal <damien.marchal@univ-lille1.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code smell.
SceneLoaderListernerderives fromSceneLoader::Listener. The classSceneLoader::Listenerhas a methodrightBeforeLoadingSceneaccepting aSceneLoader*. ButSceneLoaderListernerdoes not overload it. Instead, it define another methodrightBeforeLoadingScenewith a different signature. Even if it is intentional, I did not find any call of this signature. So my guess is a wrong overriding of the base method.However, now that it's properly implemented, I don't know the effects of this call...