[image] Apply new factory registration mechanism by hugtalbot · Pull Request #5773 · sofa-framework/sofa

hugtalbot · 2025-11-11T12:22:19Z

Assess that other PRs are passing using :
[ci-depends-on https://github.com/sofa-framework/CSparseSolvers/pull/6]
[ci-depends-on https://github.com/sofa-framework/CGALPlugin/pull/39]
[ci-depends-on https://github.com/sofa-framework/Registration/pull/29]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

hugtalbot · 2025-11-11T12:22:42Z

[ci-build][with-all-tests]

applications/plugins/image/initImage.cpp

sofabot · 2025-11-13T16:11:20Z

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

hugtalbot · 2025-11-13T18:05:04Z

[ci-build][force-full-build]

sofabot · 2025-11-13T18:05:18Z

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

applications/plugins/image/initImage.cpp

sofabot · 2025-11-14T14:22:24Z

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

sofabot · 2025-11-17T08:55:59Z

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

sofabot · 2025-11-17T11:31:24Z

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

epernod · 2025-11-19T10:22:27Z

red red red :/

sofabot · 2025-11-19T15:07:30Z

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

sofabot · 2025-11-19T16:19:36Z

[ci-depends-on] detected during build #11.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

fredroy · 2025-11-20T01:14:19Z

applications/plugins/image/initImage.cpp

+    extern void registerCollisionToCarvingEngine(sofa::core::ObjectFactory* factory);
+
+#ifdef SOFA_BUILD_TESTS
+    extern void registerTestImageEngine(sofa::core::ObjectFactory* factory);


This will never work as the definition of registerTestImageEngine is in an other Translation Unit so the symbol will never be defined at link stage. And image is a dep of image_test, not the other way around

sofabot · 2025-11-20T01:21:58Z

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

hugtalbot · 2025-11-20T08:08:17Z

[ci-build][force-full-build]

sofabot · 2025-11-20T08:08:33Z

[ci-depends-on] detected during build #13.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='992e4676975804f9ed0bfa15c03d441a6e26be72'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

hugtalbot · 2025-11-23T15:12:21Z

[ci-build][with-all-tests]

sofabot · 2025-11-23T15:12:35Z

[ci-depends-on] detected during build #14.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='3928478f08729a359cd812faef0e8488d140ee18'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

hugtalbot · 2025-11-23T18:50:50Z

I got it @fredroy @epernod ✊
Cheers

sofabot · 2025-11-23T18:51:23Z

[ci-depends-on] detected during build #15.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='3928478f08729a359cd812faef0e8488d140ee18'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

sofabot · 2025-11-25T15:07:07Z

[ci-depends-on] detected during build #16.

To unlock the merge button, you must

Merge or close Apply new factory registration mechanism CSparseSolvers#6
For this build, the following CMake flags will be set
-DCSPARSESOLVERS_GIT_REPOSITORY='https://github.com/sofa-framework/CSparseSolvers'
-DCSPARSESOLVERS_GIT_TAG='b926afbec4be3bf27240e0d236197370dc8fab4a'
Merge or close Apply new factory registration mechanism CGALPlugin#39
For this build, the following CMake flags will be set
-DCGALPLUGIN_GIT_REPOSITORY='https://github.com/sofa-framework/CGALPlugin'
-DCGALPLUGIN_GIT_TAG='3928478f08729a359cd812faef0e8488d140ee18'
Merge or close Apply new factory registration mechanism Registration#29
For this build, the following CMake flags will be set
-DREGISTRATION_GIT_REPOSITORY='https://github.com/sofa-framework/Registration'
-DREGISTRATION_GIT_TAG='417227efded56f920bc2c79e7c8ae4044cd23568'

fredroy · 2025-11-25T15:09:43Z

[ci-build][with-all-tests][force-full-build]

sofabot · 2025-11-25T15:09:54Z

[ci-depends-on] detected during build #17.

All dependencies are merged/closed. Congrats! 👍

hugtalbot added this to Refactor object registration Nov 11, 2025

hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 11, 2025

epernod force-pushed the 202511_image_new_registration_mechanism branch from 86309b6 to d68be99 Compare November 13, 2025 08:05

epernod approved these changes Nov 13, 2025

View reviewed changes

hugtalbot changed the title ~~Apply new factory registration mechanism~~ [image] Apply new factory registration mechanism Nov 13, 2025

hugtalbot commented Nov 13, 2025

View reviewed changes

applications/plugins/image/initImage.cpp Outdated Show resolved Hide resolved

hugtalbot commented Nov 14, 2025

View reviewed changes

applications/plugins/image/initImage.cpp Outdated Show resolved Hide resolved

hugtalbot commented Nov 14, 2025

View reviewed changes

applications/plugins/image/initImage.cpp Outdated Show resolved Hide resolved

fredroy reviewed Nov 20, 2025

View reviewed changes

hugtalbot added 3 commits November 25, 2025 16:06

Apply new factory registration mechanism

2fabb66

Add test and toolbox from image plugin

19e91fb

Fix #if into #ifdef in initImage

ea646b8

hugtalbot and others added 7 commits November 25, 2025 16:06

Apply suggestions from code review

36044be

Apply suggestions from code review

db93cc2

add == 1 condition

c5b8958

add aanother if

b90f75a

keep only ifdef SOFA_BUILD_TESTS

791ec39

fix compilation of image with eigenv5

02d250a

call registation when executing image_test

d68cf6f

fredroy force-pushed the 202511_image_new_registration_mechanism branch from f4f3c88 to d68cf6f Compare November 25, 2025 15:06

fredroy approved these changes Nov 25, 2025

View reviewed changes

fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 25, 2025

fredroy merged commit c70d43e into sofa-framework:master Nov 25, 2025
13 of 15 checks passed

github-project-automation bot moved this to Done in Refactor object registration Nov 25, 2025

hugtalbot added this to the v25.12 milestone Jan 5, 2026

bakpaul changed the title ~~[image] Apply new factory registration mechanism~~ [image] Apply new factory registration mechanism Feb 3, 2026

Conversation

hugtalbot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugtalbot commented Nov 11, 2025

Uh oh!

Uh oh!

sofabot commented Nov 13, 2025

Uh oh!

hugtalbot commented Nov 13, 2025

Uh oh!

sofabot commented Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

sofabot commented Nov 14, 2025

Uh oh!

sofabot commented Nov 17, 2025

Uh oh!

sofabot commented Nov 17, 2025

Uh oh!

epernod commented Nov 19, 2025

Uh oh!

sofabot commented Nov 19, 2025

Uh oh!

sofabot commented Nov 19, 2025

Uh oh!

fredroy Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sofabot commented Nov 20, 2025

Uh oh!

hugtalbot commented Nov 20, 2025

Uh oh!

sofabot commented Nov 20, 2025

Uh oh!

hugtalbot commented Nov 23, 2025

Uh oh!

sofabot commented Nov 23, 2025

Uh oh!

hugtalbot commented Nov 23, 2025

Uh oh!

sofabot commented Nov 23, 2025

Uh oh!

sofabot commented Nov 25, 2025

Uh oh!

fredroy commented Nov 25, 2025

Uh oh!

sofabot commented Nov 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hugtalbot commented Nov 11, 2025 •

edited

Loading

fredroy Nov 20, 2025 •

edited

Loading