Conversation
fahmed10
commented
Mar 24, 2026
fahmed10
commented
- Moved posters into a separate database
…connection string
…d + updated table format
cengique
requested changes
Apr 3, 2026
README.md
Outdated
| password: '', // left blank; filled in after login | ||
|
|
||
| judgesDB: 'DBname', | ||
| postersDB: 'DBname', |
Member
There was a problem hiding this comment.
these should be read from the configuration database
README.md
Outdated
| @@ -121,6 +121,7 @@ export const environment = { | |||
Member
There was a problem hiding this comment.
these fields should probably be removed as the login is taken from user
src/app/services/pouchdb.service.ts
Outdated
| console.warn('[getPosters] posters_json is invalid.'); | ||
| return []; | ||
| } | ||
| let posterDocs = await new PouchDB(`${environment.couch.protocol}://${environment.couch.username}:${environment.couch.password}@${environment.couch.host}:${environment.couch.port}/${environment.couch.postersDB}`).allDocs({ include_docs: true }); |
Member
There was a problem hiding this comment.
read the name for postersDB from configuration instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.