Skip to content

Drop six, drop some Py2 backcompat code.#408

Merged
tacaswell merged 1 commit intosoft-matter:mainfrom
anntzer:seven
Apr 12, 2022
Merged

Drop six, drop some Py2 backcompat code.#408
tacaswell merged 1 commit intosoft-matter:mainfrom
anntzer:seven

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Apr 8, 2022

The numpy>=1.19 bound effectively means Python2 is no longer supported.

@tacaswell
Copy link
Copy Markdown
Member

rebased due to conflicts in with #392 .

The numpy>=1.19 bound effectively means Python2 is no longer supported.
@tacaswell
Copy link
Copy Markdown
Member

It looks like imageio 2.16.2 (released yestreday) added warnings for migrating to a their v3 API (which looks nice! https://imageio.readthedocs.io/en/stable/reference/userapi.html#migrating-to-the-v3-api) but this is causing warnings in both our code and skimage.

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Apr 12, 2022

Looks like we both rebased at the same time :)
The fix wrt imageio is probably just a bunch of version-dependent imports, but will depend on how far back you want to support (imageio.v2 only exists since imageio 2.16.0), so I'll you decide on that.

@tacaswell tacaswell closed this Apr 12, 2022
@tacaswell tacaswell reopened this Apr 12, 2022
@tacaswell tacaswell merged commit ab00b0a into soft-matter:main Apr 12, 2022
@tacaswell
Copy link
Copy Markdown
Member

"fixed" the failures by pinning imageIO back and created #411 to track the need to fix this.

@anntzer anntzer deleted the seven branch April 12, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants