FIX: PyAVReaderTimed.close does not close container#447
Open
EitanHemed wants to merge 2 commits intosoft-matter:mainfrom
Open
FIX: PyAVReaderTimed.close does not close container#447EitanHemed wants to merge 2 commits intosoft-matter:mainfrom
EitanHemed wants to merge 2 commits intosoft-matter:mainfrom
Conversation
…ther the object's container is closed (_is_container_closed). The __del__ method handles a case where _container is closed (and hence a NoneType).
…xt manager functionality to close the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes to fix #446 -
PyAVReaderTimed._containerwas not closing upon callingPyAVReaderTimed.close(). This allows for also existing context (with) properly. Cached frames are still available.