Fix MoviePy import to ensure compatibility with version 2.X#472
Open
NerdyN00B wants to merge 2 commits intosoft-matter:mainfrom
Open
Fix MoviePy import to ensure compatibility with version 2.X#472NerdyN00B wants to merge 2 commits intosoft-matter:mainfrom
NerdyN00B wants to merge 2 commits intosoft-matter:mainfrom
Conversation
fixed moviepy import to no longer use moviepy.editor for compatibility with moviepy 2.X
Fixed moviepy import from moviepy.editor to just moviepy in order to ensure compatibility with moviepy 2.X
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoviePy 2.X no longer uses
moviepy.editor(see https://zulko.github.io/moviepy/getting_started/updating_to_v2.html).This should change all occurrences of
moviepy.editorto simplymoviepy.I'm unsure if it might be best practice to try both
from moviepy import ...andfrom moviepy.editor import ...to ensure compatibility with both versions. This only ensures compatibility with newer versions of MoviePy