CLN: Moved empty-level check to wrap kdtree.query()#359
Merged
caspervdw merged 1 commit intosoft-matter:masterfrom Apr 26, 2016
Merged
CLN: Moved empty-level check to wrap kdtree.query()#359caspervdw merged 1 commit intosoft-matter:masterfrom
caspervdw merged 1 commit intosoft-matter:masterfrom
Conversation
Contributor
Author
|
Please ignore the first failed Travis check. I accidentally pushed the branch to |
Member
|
Looks good, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the check for empty levels into
assign_candidates, because the check addresses a shortcoming of cKDTree specifically. See #293 (comment) and #293 (comment) for motivation.