Migrate and refactor data import/export - #18
Merged
javihgil merged 2 commits intoMar 26, 2026
Conversation
AritzPalaciosOrtiz
previously approved these changes
Mar 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR migrates the blog plugin’s data import/export wiring from softspring/cms-bundle data components to the newer softspring/cms-data-plugin, and makes the Data services only load when the data plugin is present.
Changes:
- Conditionally load Data-related service definitions when
SfsCmsDataPluginis available. - Update
ArticleEntityTransformerto extend/usesoftspring/cms-data-plugintransformer and support classes. - Split Data service registration into a separate
data_plugin_services.yaml.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/DependencyInjection/SfsCmsBlogExtension.php |
Conditionally loads data_plugin_services.yaml when the data plugin class exists. |
src/Data/EntityTransformer/ArticleEntityTransformer.php |
Switches imports/parent class to softspring/cms-data-plugin equivalents. |
config/services/services.yaml |
Removes unconditional registration of Softspring\CmsBlogPlugin\Data\ services. |
config/services/data_plugin_services.yaml |
Adds Data service registration behind the conditional load. |
composer.json |
Adds softspring/cms-data-plugin as a dev dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javihgil
deleted the
migrate-import-export-features-to-new-cms-data-plugin
branch
March 26, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.