Add twig section render functions - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds Twig section render functions to the CMS sections plugin, providing template functions for finding and rendering sections in different modes (embed, ESI, and AJAX).
Key changes:
- Introduces a new RenderExtension class with multiple Twig functions for section operations
- Updates service configuration to register all Twig extensions instead of just admin-specific ones
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/Twig/Extension/RenderExtension.php | New Twig extension providing section finding and rendering functions |
| config/services/admin_services.yaml | Updated service registration to include all Twig extensions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new functions for twig:
sfs_cms_section_find
sfs_cms_section_find_by_*
sfs_cms_section
sfs_cms_section_embed
sfs_cms_section_embed_by_
sfs_cms_section_esi
sfs_cms_section_esi_by_
sfs_cms_section_ajax
sfs_cms_section_ajax_by_