Fix admin bug with sections preview - #5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes an admin bug with section previews by ensuring that site and locale parameters are properly passed through when rendering sections in admin preview mode. The changes handle multiple parameter sources (query parameters and request attributes) and add support for different rendering modes (ESI, AJAX, and standard).
Changes:
- Added admin preview detection from query parameters in the SectionController
- Improved site and locale parameter handling with multiple fallback sources
- Updated Twig template to pass admin preview context and site information through all rendering modes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Controller/SectionController.php | Added LocaleSwitcher dependency, enhanced admin preview detection from query parameters, improved site/locale parameter resolution with fallbacks |
| cms/modules/section/render.html.twig | Added admin preview detection, updated all three rendering modes (ESI, AJAX, standard) to pass admin preview and site parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AritzPalaciosOrtiz
previously approved these changes
Feb 24, 2026
evabelpeq
previously approved these changes
Feb 25, 2026
javihgil
dismissed stale reviews from evabelpeq and AritzPalaciosOrtiz
via
February 25, 2026 07:36
fde9e6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.