feat: Shell-less entry functions, createComputePipeline, createRenderPipeline #1835
+2,603
−1,157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
iwoplaza
changed the title
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:
Dynamic test results:
📋 All resultsClick to reveal the results table (323 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
lursz and
reczkok
aleksanderkatan
approved these changes
Jan 14, 2026
Contributor
aleksanderkatan
left a comment
aleksanderkatan
left a comment
There was a problem hiding this comment.
Docs (including pipeline docs) still use the old API, is this meant for another ticket?
Comment on lines
+8
to
+15
| const fromColor = root.createUniform(d.vec3f); | ||
| const polarCoords = root.createUniform(d.u32); | ||
| const squashed = root.createUniform(d.u32); | ||
| const toColor = root.createUniform(d.vec3f); | ||
| const sharpness = root.createUniform(d.f32); | ||
| const distortion = root.createUniform(d.f32); | ||
| const time = root.createUniform(d.f32); | ||
| const grainSeed = root.createUniform(d.f32); |
Contributor
There was a problem hiding this comment.
Even an example like this can get kind of close to the uniform limit per bind group (12). Have we considered possible approaches to amend this?
The number of uniform buffers (13) in the Vertex stage exceeds the maximum per-stage limit (12).
- While validating binding counts
- While validating [BindGroupLayoutDescriptor ""<unnamed> - Automatic Bind Group & Layout""]
- The error is readable, so users can just figure out that they can wrap these values into a single struct to only use 1 binding (though this may be non-trivial for new users).
- We could check the limits ourselves and throw more descriptive errors.
- We could group primitive uniforms into a struct ourselves.
- We could "bleed" the elements over the limit to another catch-all bind groups.
Collaborator
Author
There was a problem hiding this comment.
The 4th "bleed" solution was my head canon for a while, though I would prefer if we intervened as little as possible. With that in mind, the 3rd would be even more invasive.
I think I'd prefer the 2nd solution for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-10-18.at.11.53.56.mov