Skip to content

feat(scarb-prove): expose --proof-format flag for cairo_serde output #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciektr merged 2 commits into from
May 28, 2026
Merged

feat(scarb-prove): expose --proof-format flag for cairo_serde output #3125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9046a3
feat(scarb-prove): expose --proof-format flag for cairo_serde output
May 16, 2026
e1c257c
remove old dep
maciektr May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion extensions/scarb-prove/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ heavy-tests = []

[dependencies]
anyhow.workspace = true
cairo-air.workspace = true
camino.workspace = true
clap.workspace = true
create-output-dir = { path = "../../utils/create-output-dir" }
Expand Down
3 changes: 1 addition & 2 deletions extensions/scarb-prove/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#![deny(clippy::disallowed_methods)]

use anyhow::{Context, Result, bail, ensure};
use cairo_air::utils::ProofFormat;
use camino::{Utf8Path, Utf8PathBuf};
use clap::Parser;
use create_output_dir::create_output_dir;
Expand Down Expand Up @@ -105,7 +104,7 @@ fn main_inner(args: Args, ui: Ui) -> Result<()> {
prover_input,
false,
proof_path.as_std_path().to_path_buf(),
ProofFormat::Json,
args.proof_format,
None,
)?;

Expand Down
3 changes: 2 additions & 1 deletion utils/scarb-extensions-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ publish = false
anyhow = { workspace = true, optional = true }
clap.workspace = true
camino = { workspace = true, optional = true }
cairo-air = { workspace = true, optional = true }
cairo-vm = { workspace = true, optional = true }
scarb-ui = { path = "../scarb-ui", optional = true }

Expand All @@ -24,7 +25,7 @@ execute = [
"cairo-vm/clap"
]
mdbook = ["dep:camino", "dep:scarb-ui"]
prove = ["execute", "dep:scarb-ui"]
prove = ["execute", "dep:cairo-air", "dep:scarb-ui"]
verify = ["dep:camino", "dep:scarb-ui"]
default = [
"cairo-language-server",
Expand Down
5 changes: 5 additions & 0 deletions utils/scarb-extensions-cli/src/prove.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
//! Extension CLI arguments datastructures.

use crate::execute::ExecutionArgs;
use cairo_air::utils::ProofFormat;
use clap::Parser;
use scarb_ui::args::{PackagesFilter, VerbositySpec};

Expand Down Expand Up @@ -51,6 +52,10 @@ pub struct Args {
#[arg(long, env = "SCARB_OUTPUT_JSON")]
pub json: bool,

/// Format used to serialize the generated proof.
#[arg(long, value_enum, default_value_t = ProofFormat::Json)]
pub proof_format: ProofFormat,

/// Logging verbosity.
#[command(flatten)]
pub verbose: VerbositySpec,
Expand Down
Loading