Setup sourcegraph for scala 3#369
Open
ghostbuster91 wants to merge 4 commits intosoftwaremill:scala3from
Open
Conversation
ghostbuster91
force-pushed
the
setup-sourcegraph
branch
from
6a163f9 to
e752b14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR apart from adding integration with sourcegraph also unifies how java is being set.
The unification part can be revert or done otherwise if desired.
actions/setup-java@v1supports only one distribution - Zulu OpenJDK (Note that v2 supports wider variety of distributions)That means PR also changes openjdk distro which is used by the CI pipeline.
While I believe that both changes (unification and switch to Zulu) are beneficial I can agree that they might be split into multiple PRs for better transparency (if needed).