Use new gRPC matcher for README example#90
Open
johanbrandhorst wants to merge 1 commit into
Open
Conversation
gRPC-Go has been waiting for the settings frame for a while now (soheilhy#64), and having the old handler in the example is confusing users (soheilhy#67). Use the new handler in the example and remove the "Limitations" from the README.
|
Meet the same issue, please merge this PR. |
|
still a problem. @soheilhy would an update to the "Limitations" section to include "golang and other c-wrapped implementations" be more amenable? As I understand it the performance issue with MatchWithWriters (caused by sending settings more than once) was resolved, so maybe it's ok to change the default example now |
|
Glad i found this... mucked around for hours wondering what the issue was. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC-Go has been waiting for the settings frame for a while now (#64),
and having the old handler in the example is confusing users (#67).
Use the new handler in the example and remove the "Limitations" from the README.