Skip to content

add pinocchio nft-operations example #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkFeder wants to merge 1 commit into
base: main
Choose a base branch
from
+2,295 −1
Open

add pinocchio nft-operations example #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ members = [

# tokens
"tokens/escrow/pinocchio/program",
"tokens/nft-operations/pinocchio/program",
"tokens/transfer-tokens/pinocchio/program",
"tokens/token-2022/mint-close-authority/native/program",
"tokens/token-2022/non-transferable/native/program",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ How to store state that changes size in Solana.

Create an NFT collection, mint NFTs, and verify NFTs as part of a collection using Metaplex Token Metadata.

[anchor](./tokens/nft-operations/anchor)
[anchor](./tokens/nft-operations/anchor) [pinocchio](./tokens/nft-operations/pinocchio)

### Minting a token from inside a program

Expand Down
8 changes: 8 additions & 0 deletions tokens/nft-operations/pinocchio/cicd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash

# This script is for quick building & deploying of the program.
# It also serves as a reference for the commands used for building & deploying Solana programs.
# Run this bad boy with "bash cicd.sh" or "./cicd.sh"

cargo build-sbf --manifest-path=./program/Cargo.toml --sbf-out-dir=./program/target/so
solana program deploy ./program/target/so/program.so

@greptile-apps greptile-apps Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Deploy Path Skips Built Artifact

The build step writes the SBF output with the crate-derived name, nft_operations_pinocchio_program.so. This deploy command still looks for program.so, so bash cicd.sh fails at deploy time even after a successful build.

Suggested change
solana program deploy ./program/target/so/program.so
solana program deploy ./program/target/so/nft_operations_pinocchio_program.so

@MarkFeder MarkFeder Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the package.json deploy note: cicd.sh is a reference convenience script, not part of CI (CI builds to ./tests/fixtures via build-and-test). The program.so path is the shared convention used by the merged pinocchio examples on main (escrow, transfer-tokens), so this stays consistent with the rest of the series.

@greptile-apps greptile-apps Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point — if escrow and transfer-tokens use the same program.so convention in their cicd.sh scripts, consistency across the series is the right call. I'll drop this comment.

@MarkFeder MarkFeder Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the package.json deploy note: cicd.sh is a reference convenience script, not part of CI (CI builds to ./tests/fixtures via build-and-test). The program.so path is the shared convention used by the merged pinocchio examples on main (escrow, transfer-tokens), so this stays consistent with the rest of the series.

24 changes: 24 additions & 0 deletions tokens/nft-operations/pinocchio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"type": "module",
"scripts": {
"postinstall": "node prepare.mjs",
"test": "pnpm ts-mocha -p ./tsconfig.json -t 1000000 ./tests/test.ts",
"build-and-test": "cargo build-sbf --manifest-path=./program/Cargo.toml --sbf-out-dir=./tests/fixtures && pnpm test",
"build": "cargo build-sbf --manifest-path=./program/Cargo.toml --sbf-out-dir=./program/target/so",
"deploy": "solana program deploy ./program/target/so/program.so"

@greptile-apps greptile-apps Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Deploy Script Uses Missing Binary

cargo build-sbf emits the shared object using the crate name, nft_operations_pinocchio_program.so, not program.so. Running pnpm deploy after pnpm build therefore points solana program deploy at a file that was not produced.

Suggested change
"deploy": "solana program deploy ./program/target/so/program.so"
"deploy": "solana program deploy ./program/target/so/nft_operations_pinocchio_program.so"

@MarkFeder MarkFeder Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy script here is a convenience/reference command and is not exercised by CI — CI runs build-and-test, which builds with --sbf-out-dir=./tests/fixtures and never invokes deploy. The program.so path matches the established convention across the merged pinocchio examples (e.g. tokens/escrow/pinocchio and tokens/transfer-tokens/pinocchio on main both use solana program deploy ./program/target/so/program.so). Keeping it identical here avoids making this one example diverge from its siblings.

@MarkFeder MarkFeder Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy script here is a convenience/reference command and is not exercised by CI — CI runs build-and-test, which builds with --sbf-out-dir=./tests/fixtures and never invokes deploy. The program.so path matches the established convention across the merged pinocchio examples (e.g. tokens/escrow/pinocchio and tokens/transfer-tokens/pinocchio on main both use solana program deploy ./program/target/so/program.so). Keeping it identical here avoids making this one example diverge from its siblings.

@greptile-apps greptile-apps Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point — if tokens/escrow/pinocchio and tokens/transfer-tokens/pinocchio both use the same program.so path convention, keeping this consistent is the right call. The deploy script is a non-CI reference command, so diverging from the established pattern would only create unnecessary inconsistency.

I'll withdraw the comment. Thanks for the context.

@greptile-apps greptile-apps Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point — if the existing pinocchio examples (escrow, transfer-tokens) already use program.so in their deploy scripts under the same convention, keeping this example consistent is the right call. The deploy script being a non-CI reference command makes the inconsistency acceptable, and diverging from siblings would be the worse outcome.

I'll withdraw the concern. Thanks for the context.

Shall I remember this as a rule: "The deploy script in pinocchio examples uses program.so as a convention — do not flag it as a bug since it is a non-CI reference command intentionally consistent with sibling examples"?

},
"dependencies": {
"@solana/web3.js": "^1.98.4",
"borsh": "^2.0.0"
},
"devDependencies": {
"@types/bn.js": "^5.1.0",
"@types/chai": "^4.3.1",
"@types/mocha": "^9.1.1",
"chai": "^4.3.4",
"mocha": "^9.0.3",
"solana-bankrun": "^0.3.0",
"ts-mocha": "^10.0.0",
"typescript": "^4.3.5"
}
}
Loading
Loading