fix(webapp): keep select dropdowns usable inside dialogs#147
Merged
Conversation
Modal dialogs (Radix react-remove-scroll + pointer-events lockout) broke the portaled base-ui Select popups: options weren't clickable, the list couldn't wheel-scroll, and clicking an option dismissed the dialog. Mark dialogs that contain Selects as non-modal, re-enable pointer events on listbox popups, and ignore outside-interactions that originate from a select popup so the dialog stays open on selection.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Compute Unit Report
Generated: 2026-06-02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-remove-scroll+ pointer-events lockout) broke the portaled base-uiSelectpopups inside them: options weren't clickable, the list couldn't wheel-scroll, and clicking an option dismissed the dialog.pointer-eventson listbox popups and ignore outside-interactions originating from a select popup (sharedDialogContent) so the dialog stays open on selection.Selecteverywhere (no native fallback); hour pickers stay hour-only (no minutes).Test Plan
pnpm --filter webapp build— clean.Notes