This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is building on top of #6 by @vekexasia
Most notaby, this encodes
undefinedproperty names in thePtype, which is used inStructureto omit fields without a property name.A note on the approach, the class constructors are more loosely typed, while the constructor functions have overloads with stricter types.
This PR includes a typed examples test file to give an idea that it works, but the tests are pretty minimal and there's no negative tests (i.e. tests that compilation fails) despite that kinda being the goal of the type enhancements.