program: Add delegate support to unwrap_lamports#1061
Merged
Conversation
joncinque
changed the title
unwrap_lamportsunwrap_lamports
joncinque
reviewed
Mar 25, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just a nit, looks great overall!
| /// * Single owner/delegate | ||
| /// 0. `[writable]` The source account. | ||
| /// 1. `[writable]` The destination account. | ||
| /// 2. `[signer]` The source account's owner/delegate. |
Contributor
There was a problem hiding this comment.
Haha I didn't realize we even advertised it here
Comment on lines
+1786
to
+1788
| if delegated_amount < amount { | ||
| return Err(TokenError::InsufficientFunds.into()); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: Do we need this check? we're doing a checked_sub anyway, so may as well just change the error to TokenError::InsufficientFunds on the checked math and remove this check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently it is not possible to use a delegate to
unwrap_lamports.Solution
Add delegate support to
unwrap_lamports. The delegate implementation works similarly to how it works ontransfer:This brings the implementation in-line with p-token (solana-program/token#120).