Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1176 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 404 404
Lines 10635 10647 +12
=======================================
+ Hits 10445 10457 +12
Misses 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release of Solr 10 necessitated a re-evaluation of the workaround for SOLR-6853. It breaks for Solr 10. Removing the workaround breaks backward compatibility. Since all affected Solr versions are now EOL, and the next Solarium release will be a new major version, I took this opportunity to revert the workaround so an out-of-the-box Solarium 7 will work with an out-of-the-box Solr 10. You can still opt-in to the workaround if needed, this information was added to the docs in all relevant places.
Solr 10 no longer comes bundled with a Tika Server. I've added a Docker container for an external Tika Server to the workflow. A small adjustment to the integration test was necessary because it behaves slightly differently.
WT_PHPSis no longer supported by Solr 10. I've commented it out in the integration tests for now, pending the result of #1169.