Skip to content

General Improvement#214

Merged
xuan-cao-swi merged 23 commits into
mainfrom
general-improvement
Oct 6, 2025
Merged

General Improvement#214
xuan-cao-swi merged 23 commits into
mainfrom
general-improvement

Conversation

@xuan-cao-swi
Copy link
Copy Markdown
Contributor

@xuan-cao-swi xuan-cao-swi commented Aug 18, 2025

Description

  1. Update transaction_name code doc from DogFood to Order
  2. Update the noop api README that list available noop method
  3. Use settings.partition that allow one loop to separate enabled and disabled transaction name
  4. Use @random_generator.rand instead of rand for thread safety
  5. Rescue JSON::ParserError for specific error type
  6. Use string interpolation instead of [].join('-')
  7. Cache @sleep_interval to avoid calculation each time the bucket consume
  8. Combine header.filter and reject into one loop
  9. Update enable_disable_config that only given string for first parameters. Since it's internal method so no need to increase the complexity (nil.to_s vs '')
  10. Add mutex around update_settings to make sure settings is not in race condition.

Test (if applicable)

@xuan-cao-swi xuan-cao-swi changed the title General Improvement (WIP) General Improvement Aug 18, 2025
@xuan-cao-swi xuan-cao-swi changed the title (WIP) General Improvement General Improvement Sep 16, 2025
@xuan-cao-swi xuan-cao-swi marked this pull request as ready for review September 16, 2025 15:02
@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner September 16, 2025 15:02
Comment thread lib/solarwinds_apm/opentelemetry/otlp_processor.rb
Comment thread lib/solarwinds_apm/opentelemetry/solarwinds_propagator.rb
Comment thread lib/solarwinds_apm/opentelemetry/solarwinds_response_propagator.rb
Comment thread lib/solarwinds_apm/sampling/json_sampler.rb Outdated
Comment thread lib/solarwinds_apm/sampling/json_sampler.rb Outdated
Comment thread lib/solarwinds_apm/sampling/json_sampler.rb Outdated
Comment thread lib/solarwinds_apm/sampling/oboe_sampler.rb
Comment thread lib/solarwinds_apm/sampling/sampler.rb Outdated
Comment thread lib/solarwinds_apm/sampling/token_bucket.rb Outdated
Comment thread lib/solarwinds_apm/support/resource_detector.rb Outdated
Comment thread test/minitest_helper.rb Outdated
Comment thread test/sampling/sampler_test.rb Outdated
@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

Overall looks good and nice to see some functions factored out. I had several comments, mostly about log levels for scenarios.

xuan-cao-swi and others added 3 commits September 16, 2025 16:30
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
Comment thread lib/solarwinds_apm/opentelemetry/solarwinds_propagator.rb
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates, lgtm

@xuan-cao-swi xuan-cao-swi merged commit ac50088 into main Oct 6, 2025
14 checks passed
@xuan-cao-swi xuan-cao-swi deleted the general-improvement branch October 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants