Feature: webview Flutter onRenderProcessGone Android callback implementation#2
Open
Sinishisimus wants to merge 8 commits into
Open
Feature: webview Flutter onRenderProcessGone Android callback implementation#2Sinishisimus wants to merge 8 commits into
Sinishisimus wants to merge 8 commits into
Conversation
Sinishisimus
requested review from
KrstanovicMarko,
LugonjaAleksandar,
VukVL,
doriansabo,
filipljusic and
petarsolrise
and removed request for
a team
LugonjaAleksandar
approved these changes
Mar 10, 2025
Comment on lines
+51
to
+54
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter: {path: ../../../webview_flutter/webview_flutter}, webview_flutter_android: {path: ../../../webview_flutter/webview_flutter_android}, webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}, webview_flutter_wkwebview: {path: ../../../webview_flutter/webview_flutter_wkwebview}} No newline at end of file |
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+48
to
+52
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_android: {path: ../../webview_flutter/webview_flutter_android}, webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}, webview_flutter_wkwebview: {path: ../../webview_flutter/webview_flutter_wkwebview}} | ||
|
|
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+33
to
+36
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_android: {path: ../../../webview_flutter/webview_flutter_android}, webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}} |
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+37
to
+40
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}} |
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+33
to
+36
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}} |
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+33
to
+37
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}} | ||
|
|
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+40
to
+43
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}, webview_flutter_wkwebview: {path: ../../../webview_flutter/webview_flutter_wkwebview}} |
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
Comment on lines
+42
to
+45
| # FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE. | ||
| # See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins | ||
| dependency_overrides: | ||
| {webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}} |
There was a problem hiding this comment.
Do we remove it now? if all the rest is ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.