feat: design qa multi theming improvements#2751
feat: design qa multi theming improvements#2751auroraVasconcelos wants to merge 108 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 1856c86 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
|
🚀 Storybook has been deployed for branch |
|
@van-nguyen-ht qa can be done as soon as chromatic is available. Let’s quickly talk when this is ready. |
|
@auroraVasconcelos could we generate screenshots onto which we can put comments where adjustments need to be made? |
mariohamann
left a comment
There was a problem hiding this comment.
Still no fallbacks from what I see.
| --sd-video--play-button-color-background: 255 255 255 / 0.8; | ||
| --sd-video--play-button-color-icon-fill: var(--sd-color-primary); | ||
| } | ||
|
|
There was a problem hiding this comment.
Add note:
"Deprecated variables – manually overriding these in custom themes might lead to problems in future versions of Solid. Use the actual used value instead. Example:
Instead of --sd-chip-border-width use --sd-marker-border-width--sd-marker-border-width for your overrides."
Description:
Closes #2787, closes #2739, closes #2789, closes #2740, closes #2815, closes #2805
Definition of Reviewable: