Restore Globalize: Fix gem dependencies and sandbox#155
Restore Globalize: Fix gem dependencies and sandbox#155fthobe wants to merge 7 commits intosolidusio-contrib:mainfrom
Conversation
After this change [solidusio/solidus@16fcb10](solidusio/solidus@16fcb10) The command `bundle exec rake` started failing with the following error: ``` An error occurred in a `before(:suite)` hook. Failure/Error: //= link_directory ../javascripts .js Sprockets::ArgumentError: link_directory argument must be a directory ``` - Ensure that the correct directory is specified in the manifest file to avoid the `Sprockets::ArgumentError`.
Update the globalize dependency to ~> 7.0. https://github.com/globalize/globalize/releases/tag/v7.0.0
Update en.yml to display accurate resource names on the crumbs of globalize pages.
Added default value on `friendly_id_slugs` table to prevent not null constraint violation while gem installation.
|
@fthobe sure. any idea why the specs are failing? |
|
@tvdeyen because we are idiots. Let me check. |
|
@JustShah I looked at the tests and they all look like backend failures. Let's look at them next week. |
|
@jarednorman we are going to bring this into working state and switch to mobility afterwards. As you are already working on it we would appreciate if you have any additional comments. |
|
@tvdeyen do you want to use the chance to update to github actions here as well? |
jarednorman
left a comment
jarednorman
left a comment
There was a problem hiding this comment.
This is looking good. I'm wondering about the "Update Sandbox script" commit. Was this just pulled in from a more up-to-date extension? Should we instead be running the solidus_dev_support upgrade?
@JustShah can reply to that. |
Hey @jarednorman , The "Update Sandbox script" commit was indeed pulled in from a more up to date extension. The previous version was outdated as it did not utilize the Starter Frontend and was installing Solidus Auth separately, which is no longer necessary. To address these issues, the script has been revised by referencing the latest practices from Solidus Braintree and Solidus Subscription |
|
Does the extension need a solidus_dev_support upgrade? |
If not neccessary, I would prefer to kill this off and move to mobility. By account of the globalize maintainers, it is a dead man walking, mobility looks very backward compatible to me. @jarednorman @tvdeyen @kennyadsl Offering a totally not asked for 3rd party opinion something that should:
On the risk of highjacking this, I would actually consider to make breaking change in the new migration. I am sure that mayur can get this over the finish line. This would allow us to reduce the number of extensions from three (static / i18 / globalize) to two (multilanguage / multilanguage and content). |
|
@JustShah attribution must be given, please provide the link to the repos which you have used. |
|
What about a new extension called solidus_mobility as first iteration? It looks like the safer and cleaner path to me. |
|
That's definetly the way to go
|
5 participants
This PR has no functional changes and just updates the Gem Dependencies.
@jarednorman @tvdeyen to you want to merge this into main?