Rubocop config: Use plugins for rubocop-rails and rubocop-performance#233
Closed
mamhoff wants to merge 2 commits intosolidusio:mainfrom
Closed
Rubocop config: Use plugins for rubocop-rails and rubocop-performance#233mamhoff wants to merge 2 commits intosolidusio:mainfrom
mamhoff wants to merge 2 commits intosolidusio:mainfrom
Conversation
Since Rubocop 1.72, we have to use plugins instead of require.
2.5 is really, really old.
tvdeyen
approved these changes
May 5, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Would like to test this with a real extension first. But this lgtm
Contributor
Author
|
Closing in favor of #234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rubocop 1.72, we have to use plugins instead of require.